Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Path in remove not normalized #3671

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix(core): Path in remove not normalized #3671

merged 2 commits into from
Nov 27, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 27, 2023

Fix #3669

@Xuanwo
fix(core): Path in remove not normalized
b2dd437 
Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member

Do we need to update test cases?

@Xuanwo
Fix tests
4249778 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit d789892 into main Nov 27, 2023
209 of 213 checks passed
@Xuanwo Xuanwo deleted the fix-remove branch November 27, 2023 14:09
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: remove should normalize file path
2 participants
@Xuanwo @suyanhanx