Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Build with redis features and Rust < 1.72 #3683

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

vincentdephily
Copy link
Contributor

Just need to be explicit about using our own redis mod rather than the redis crate.

Fixes #3595

Just need to be explicit about using our own redis mod rather than the redis crate.

Fixes apache#3595
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 10cc031 into apache:main Nov 30, 2023
35 checks passed
@Xuanwo
Copy link
Member

Xuanwo commented Nov 30, 2023

Hi, @G-XD, sorry for my fault this not include the fix for this issue in advance. Can you start a new round of VOTE that include this fix? Sccache (mozilla/sccache#1992) is waiting for this.

@vincentdephily vincentdephily deleted the fix_redis_build branch November 30, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenDAL v0.42 with service-redis enable will produce an hard error
2 participants