Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): add Huggingface behavior test #3712

Merged
merged 14 commits into from
Dec 7, 2023
Merged

feat(test): add Huggingface behavior test #3712

merged 14 commits into from
Dec 7, 2023

Conversation

morristai
Copy link
Member

Description

close: #3708

@morristai morristai changed the title feat(core): add Huggingface behavior test feat(test): add Huggingface behavior test Dec 5, 2023
@morristai morristai marked this pull request as draft December 5, 2023 02:18
@morristai morristai marked this pull request as ready for review December 5, 2023 02:31
@Xuanwo
Copy link
Member

Xuanwo commented Dec 5, 2023

Please enable OPENDAL_DISABLE_RANDOM_ROOT for hugging face.

@Xuanwo
Copy link
Member

Xuanwo commented Dec 5, 2023 •
edited

Status code 206 is ok for read.

@Xuanwo
Copy link
Member

Xuanwo commented Dec 5, 2023

hf_resolve parsed status code by self which is wrong.

@morristai
Copy link
Member Author

hf_resolve parsed status code by self which is wrong.

Sorry, I've been in a rush recently. I will carefully check in the future.

@morristai
Copy link
Member Author

It seems there's an error in the Java binding. Should we disable Java binding for now? @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Dec 6, 2023 •
edited

It seems there's an error in the Java binding. Should we disable Java binding for now? @Xuanwo

Let's invite @tisonkun & @G-XD to take a look.

@G-XD
Copy link
Contributor

G-XD commented Dec 6, 2023

It seems there's an error in the Java binding. Should we disable Java binding for now? @Xuanwo

Let's invite @tisonkun & @G-XD to take a look.

SPECIAL_DIR_NAME is wrong, I'll fix it right away.

@Xuanwo
Copy link
Member

Xuanwo commented Dec 6, 2023

SPECIAL_DIR_NAME is wrong, I'll fix it right away.

Thanks!

@G-XD G-XD mentioned this pull request Dec 6, 2023
Merged
@Xuanwo
Copy link
Member

Xuanwo commented Dec 6, 2023

Hi, @morristai, please update branch and try again, thanks!

Xuanwo
Xuanwo approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit bb1d328 into apache:main Dec 7, 2023
183 of 185 checks passed
@morristai morristai deleted the feat/huggingface_behavior_test branch December 7, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

@suyanhanx suyanhanx Awaiting requested review from suyanhanx suyanhanx is a code owner

@tisonkun tisonkun Awaiting requested review from tisonkun tisonkun is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add behavior test for Hugging Face File System
3 participants
@morristai @Xuanwo @G-XD