Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(raw): add parse_header_to_str fn #3804

Merged
merged 1 commit into from
Dec 23, 2023
Merged

refactor(raw): add parse_header_to_str fn #3804

merged 1 commit into from
Dec 23, 2023

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Dec 22, 2023 •
edited by Xuanwo

Close #3793

@hoslo hoslo requested a review from Xuanwo as a code owner December 22, 2023 09:23
@hoslo hoslo force-pushed the add_parse_header_to_str branch 4 times, most recently from d93776a to 9aae2d5 Compare December 23, 2023 08:40
@Xuanwo
Copy link
Member

Xuanwo commented Dec 23, 2023

Would you like to refactor APIs like parse_content_disposition at the same time? We can do this in next PR.

@Xuanwo Xuanwo merged commit 135b389 into apache:main Dec 23, 2023
186 checks passed
@hoslo
Copy link
Contributor Author

hoslo commented Dec 23, 2023

Would you like to refactor APIs like parse_content_disposition at the same time? We can do this in next PR.

What does it mean to change the function signature of parse_content_disposition or to replace parse_content_disposition with parse_header_to_str?

@Xuanwo
Copy link
Member

Xuanwo commented Dec 23, 2023

What does it mean to change the function signature of parse_content_disposition or to replace parse_content_disposition with parse_header_to_str?

I mean implements parse_content_disposition by parse_header_to_str to remove the duplicated code.

@hoslo hoslo mentioned this pull request Dec 25, 2023
Merged
@hoslo hoslo deleted the add_parse_header_to_str branch December 29, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding a opendal::raw::parse_header_to_str to avoid duplicate
2 participants
@hoslo @Xuanwo