Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oio::read): implement the async buffer reader #3811

Merged
merged 4 commits into from
Dec 30, 2023
Merged

feat(oio::read): implement the async buffer reader #3811

merged 4 commits into from
Dec 30, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 23, 2023

Implement the async buffer reader.

It's a little more complex than I expected. Maybe I should list each case and write more tests.

Related

#3735

@WenyXu WenyXu requested a review from Xuanwo as a code owner December 23, 2023 15:56
@WenyXu WenyXu mentioned this pull request Dec 23, 2023
Closed
11 tasks
WenyXu
WenyXu commented Dec 23, 2023
View reviewed changes
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Dec 23, 2023
View reviewed changes
core/src/raw/oio/read/test_util.rs Outdated Show resolved Hide resolved
core/src/types/operator/operator_futures.rs Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Dec 23, 2023

It's a little more complex than I expected. Maybe I should list each case and write more tests.

I feel like we can learn from tokio's BufReader.

@WenyXu WenyXu marked this pull request as draft December 25, 2023 10:36
@WenyXu WenyXu marked this pull request as ready for review December 30, 2023 06:11
@WenyXu
Copy link
Member Author

WenyXu commented Dec 30, 2023

Sorry for the delay. I spent quite a busy week🥲.

Xuanwo
Xuanwo reviewed Dec 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your effort! Here are some minor reviews.

core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Dec 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

core/src/raw/oio/read/buffer_reader.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's go!

@Xuanwo Xuanwo merged commit df325f2 into apache:main Dec 30, 2023
187 checks passed
@Xuanwo Xuanwo mentioned this pull request Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WenyXu @Xuanwo