Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services): add chainsafe support #3834

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat(services): add chainsafe support #3834

merged 1 commit into from
Dec 28, 2023

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Dec 27, 2023

Part #3823

@hoslo hoslo force-pushed the support-chainsafe branch 2 times, most recently from 6fc5d7b to cd64beb Compare December 27, 2023 10:14
Xuanwo
Xuanwo reviewed Dec 27, 2023
View reviewed changes
.env.example Outdated Show resolved Hide resolved
core/src/services/chainsafe/backend.rs Outdated Show resolved Hide resolved
core/src/services/chainsafe/backend.rs Outdated Show resolved Hide resolved
core/src/services/chainsafe/backend.rs Outdated Show resolved Hide resolved
core/src/types/scheme.rs Outdated Show resolved Hide resolved
core/src/services/chainsafe/lister.rs Outdated Show resolved Hide resolved
@hoslo hoslo force-pushed the support-chainsafe branch 3 times, most recently from d726adb to d943432 Compare December 27, 2023 13:49
Xuanwo
Xuanwo reviewed Dec 28, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM!

core/src/services/chainsafe/docs.md Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 34faf32 into apache:main Dec 28, 2023
187 checks passed
@hoslo hoslo deleted the support-chainsafe branch December 29, 2023 05:59
@Xuanwo Xuanwo mentioned this pull request Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoslo @Xuanwo