Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/python): Build all available services for python #3836

Merged
merged 7 commits into from
Dec 28, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 28, 2023

close #3736

Signed-off-by: Xuanwo <github@xuanwo.io>
@messense
Copy link
Member

I'm not very confident that this will build fine on release, we should verify it on CI before merging.

https://github.com/apache/incubator-opendal/blob/6ca583d27af0c3c7e3657a9116a28fdd5c9709f8/.github/workflows/bindings_python.yml#L61

Perhaps this should be changed to also allow triggering from workflow_dispatch so we can test it without tagging a release.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 28, 2023

I'm not very confident that this will build fine on release, we should verify it on CI before merging.

We have rcX for every release, this could be fine.

Perhaps this should be changed to also allow triggering from workflow_dispatch so we can test it without tagging a release.

Writing the if statement seems a bit complex; any suggestions for simplifying it?

@messense
Copy link
Member

Writing the if statement seems a bit complex; any suggestions for simplifying it?

#3837

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 28, 2023

Thanks a lot!

@messense
Copy link
Member

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 28, 2023

CI failed for:

error: could not find native static library `python3.7m`, perhaps an -L flag is missing?

error: could not compile `pyo3-ffi` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
💥 maturin failed
  Caused by: Failed to build a native library through cargo
  Caused by: Cargo build finished with "exit status: 101": `env -u CARGO PYO3_ENVIRONMENT_SIGNATURE="cpython-3.7-64bit" PYO3_PYTHON="/usr/local/bin/python3.7" PYTHON_SYS_EXECUTABLE="/usr/local/bin/python3.7" "cargo" "rustc" "--features" "services-all" "--target" "x86_64-unknown-linux-gnu" "--message-format" "json-render-diagnostics" "--manifest-path" "/home/runner/work/incubator-opendal/incubator-opendal/bindings/python/Cargo.toml" "--release" "--lib"`
Error: The process '/usr/bin/docker' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1702:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1685:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1579:27)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1100:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)

cc @messense, any ideas?

@messense
Copy link
Member

Seems like the --features override misses pyo3/extension-module feature.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 28, 2023

image

Cool! Thanks @messense!

@Xuanwo Xuanwo merged commit d82bcdf into main Dec 28, 2023
226 checks passed
@Xuanwo Xuanwo deleted the python-binding branch December 28, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python binding not working with gdrive.
3 participants