Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adapt the CompleteReader #3861

Merged
merged 2 commits into from
Dec 30, 2023
Merged

feat: adapt the CompleteReader #3861

merged 2 commits into from
Dec 30, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 30, 2023 •
edited

  1. Add TwoWaysReader and FourWaysReader
  2. Refactor the CompleteReader

Related

#3735

@WenyXu WenyXu requested a review from Xuanwo as a code owner December 30, 2023 10:38
@WenyXu WenyXu mentioned this pull request Dec 30, 2023
Closed
11 tasks
Xuanwo
Xuanwo reviewed Dec 30, 2023
View reviewed changes
core/src/raw/oio/read/mod.rs Outdated Show resolved Hide resolved
core/src/layers/complete.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/adapt-complete-reader branch 4 times, most recently from 76e5aa7 to b9dd733 Compare December 30, 2023 12:02
Xuanwo
Xuanwo approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 0402a2c into apache:main Dec 30, 2023
181 checks passed
@Xuanwo Xuanwo mentioned this pull request Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WenyXu @Xuanwo