Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: content-type configuration #878

Merged
merged 5 commits into from Oct 18, 2022

Conversation

ClSlaid
Copy link
Contributor

@ClSlaid ClSlaid commented Oct 17, 2022

  1. implement sync blocking_write_with
  2. implement async write_with
  3. implement content_type for OpWrite

Signed-off-by: ClSlaid cailue@bupt.edu.cn

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

fix: #875

1. implement sync blocking_write_with
2. implement async write_with
3. implement content_type for OpWrite

Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Signed-off-by: ClSlaid <cailue@bupt.edu.cn>
Cargo.toml Outdated Show resolved Hide resolved
src/object/object.rs Outdated Show resolved Hide resolved
src/object/object.rs Outdated Show resolved Hide resolved
src/ops/op_write.rs Outdated Show resolved Hide resolved
src/ops/op_write.rs Outdated Show resolved Hide resolved
src/ops/op_write.rs Outdated Show resolved Hide resolved
src/services/azblob/backend.rs Outdated Show resolved Hide resolved
Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
src/ops/op_write.rs Outdated Show resolved Hide resolved
src/ops/op_write.rs Outdated Show resolved Hide resolved
src/ops/op_write.rs Outdated Show resolved Hide resolved
src/services/azblob/backend.rs Show resolved Hide resolved
src/services/azblob/backend.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Oct 18, 2022

To move fast, let's split the content_type changes out of this PR. The write_with part looks good to me, but the changes to content_type still have much work to do.

@ClSlaid ClSlaid changed the title feat: implement sync/async write_with feat: content-type configuration Oct 18, 2022
@ClSlaid
Copy link
Contributor Author

ClSlaid commented Oct 18, 2022

To move fast, let's split the content_type changes out of this PR. The write_with part looks good to me, but the changes to content_type still have much work to do.

Done in #880

@Xuanwo
Copy link
Member

Xuanwo commented Oct 18, 2022

Thanks!

@Xuanwo Xuanwo merged commit e2e0422 into apache:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: mime types in HTTP headers
2 participants