Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a feature named trust-dns #879

Merged
merged 4 commits into from Oct 17, 2022
Merged

feat: add a feature named trust-dns #879

merged 4 commits into from Oct 17, 2022

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Oct 17, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Use feature to control whether trust-dns is enabled or not .

Fixes: #874

@Xuanwo
Copy link
Member

Xuanwo commented Oct 17, 2022

I don't want opendal to have a default feature. Can we have a disable_trust_dns?

@PsiACE
Copy link
Member Author

PsiACE commented Oct 17, 2022

I don't want opendal to have a default feature. Can we have a disable_trust_dns?

If this is disable_trust_dns, trust-dns will become some useless dependency.

Perhaps removing the default feature is enough and we just need to prompt for it in the release notes.

@PsiACE PsiACE changed the title feat: add a default feature named trust-dns feat: add a feature named trust-dns Oct 17, 2022
@Xuanwo Xuanwo merged commit fe629a9 into apache:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users not to use trust-dns
2 participants