WIP: Improve optional parameter support #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves script configuration from parameters to environment variables. This makes it easier to handle optional values which currently fails.
jthomas
added a commit
to jthomas/incubator-openwhisk-devtools
that referenced
this pull request
Jan 19, 2018
Removes dependency on apache/openwhisk-catalog#251
ddragosd
pushed a commit
to apache/openwhisk-devtools
that referenced
this pull request
Jan 25, 2018
* Add Makefile targets for adding catalog Fixes #6 * Revert catalog install to using script arguments. Removes dependency on apache/openwhisk-catalog#251
|
Will we need this if we use wskdeploy #268? |
|
we removed installCatalog.sh; closing this PR as out-of-date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've hit a bug where the script doesn't allow optional parameters, even though the script supports this.
If the
CATALOG_AUTH_KEYparameter is missing, the script will extract the value from:However, if I miss this parameter on the command-line, it assumes there are only two parameters, not three and fails. If I pass an empty string to force a null parameter, this doesn't pass through to the
source "$SCRIPTDIR/validateParameter.sh" $1 $2 $3correctly.I made an attempt to fix this by using environment variables for all parameters as they are all optional.