Skip to content

Commit

Permalink
Merging the repositories of openwhisk-cli and historic go-whisk-cli.
Browse files Browse the repository at this point in the history
  • Loading branch information
Vincent Hou committed Apr 28, 2017
2 parents a07f5f6 + a819460 commit 218ff0b
Show file tree
Hide file tree
Showing 7 changed files with 797 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .gitignore
@@ -0,0 +1,5 @@
*.js
javascript/
wsk
scripts
Godeps/_workspace
18 changes: 18 additions & 0 deletions .idea/libraries/GOPATH__openwhisk_cli_.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 34 additions & 0 deletions CONTRIBUTING.md
@@ -0,0 +1,34 @@
# Contributing to go-whisk-cli

## Proposing new features

If you would like to implement a new feature, please [raise an issue](https://github.ibm.com/BlueMix-Fabric/go-whisk-cli) before sending a pull request so the feature can be discussed.
This is to avoid you spending your valuable time working on a feature that the project developers are not willing to accept into the code base.

## Fixing bugs

If you would like to fix a bug, please [raise an issue](https://github.ibm.com/BlueMix-Fabric/go-whisk-cli) before sending a pull request so it can be discussed.
If the fix is trivial or non controversial then this is not usually necessary.

## Merge approval

The project maintainers use LGTM (Looks Good To Me) in comments on the code review to
indicate acceptance. A change requires LGTMs from two of the maintainers of each
component affected.

## Communication
Please use [Slack channel #whisk-users](https://cloudplatform.slack.com/messages/whisk_cli).
## Setup
Project was written with `Go v1.5`. It has a dependency on [go-whisk](https://github.ibm.com/BlueMix-Fabric/go-whisk), which has to be manually resolved (because of GHE).

## Testing

This repository needs unit tests.

Please provide information that helps the developer test any changes they make before submitting.

Should pass the cli integration test defined in the [main whisk project](https://github.rtp.raleigh.ibm.com/whisk-development/openwhisk/blob/master/tests/src/common/WskCli.java).

## Coding style guidelines

Use idomatic go. (try to) Document exported functions.
6 changes: 3 additions & 3 deletions Godeps/Godeps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion commands/property.go
Expand Up @@ -499,4 +499,3 @@ func parseConfigFlags(cmd *cobra.Command, args []string) error {

return nil
}

0 comments on commit 218ff0b

Please sign in to comment.