Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete default parameters for actions and packages (and annotations too) #161

Open
csantanapr opened this issue Nov 22, 2017 · 0 comments
Open

Comments

@csantanapr
Copy link
Member

@kolien commented on Mon Mar 14 2016

Using the command line interface, is it possible to delete default parameters for actions and packages once they have been defined?


@rabbah commented on Mon Mar 14 2016

Use update to define new prameters. These replace existing ones.


@kolien commented on Mon Mar 14 2016

As I understand it, this will replace existing parameters with new ones, but not delete them.


@rabbah commented on Mon Mar 14 2016

That's true, from the CLI, you can replace but not delete. If you made a direct API call, you could delete and replace the parameters.


@sjfink commented on Wed May 18 2016

Proposal : add a -dp flag to wsk action update which means "delete parameter".

Comments?


@rabbah commented on Mon Jul 18 2016

@dubeejw @mdeuser FYI.


@ioana-blue commented on Mon Jul 18 2016

Somewhat related to this: updating parameters is not additive, an update to the action code doesn't seem to remove the default param values.


@rabbah commented on Mon Jul 18 2016

when you update an action with new code, and don't specify any parameters, the POST looks like this { exec: ...} and not {exec: ..., params: []}. This is allow you to update exec but not remove annotations or parameters that are already attached to the action. The way to remove the parameters through the CLI will require a solution as suggested by @sjfink above.


@rabbah commented on Tue Mar 14 2017

To allow incremental updates (add/delete) individual parameters and annotations, we need an API change. This may be best done as part of the "v2" of the API; we can treat parameters and annotations as subresources of the action as in /api/v2/actions/ns/pkg/name/parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant