Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support optional leading slash in fully qualified names #75

Closed
rabbah opened this issue Oct 8, 2017 · 2 comments
Closed

support optional leading slash in fully qualified names #75

rabbah opened this issue Oct 8, 2017 · 2 comments

Comments

@rabbah
Copy link
Member

rabbah commented Oct 8, 2017

the leading slash in a fully qualified name is optional but appears to break the library here if it's not specified.

for reference, see: apache/openwhisk#2328

@jthomas
Copy link
Member

jthomas commented Nov 9, 2017

The client library currently supports the following resource identifiers.

- resource_name
- package/resource_name
- /namespace/resource_name
- /namespace/package/resource_name

If we want to support a missing forward-slash for fully qualified names, how does the API differentiate between package/action and namespace/action.

Does it only support that the missing forward slash for actions within packages?

@rabbah
Copy link
Member Author

rabbah commented Nov 9, 2017

This is the backend change that was implemented for reference in the cli https://github.com/apache/incubator-openwhisk/pull/2424/files

Three parts: unambiguous hence can drop leading slash.

jthomas pushed a commit to jthomas/openwhisk-client-js that referenced this issue Nov 9, 2017
csantanapr pushed a commit that referenced this issue Nov 10, 2017
* Remove "experimental" API Gateway support.

Fixes #52

* 3.7.0

* 3.8.0

* Adding supporting for `responsetype` for route creation.

* 3.9.0

* Add support for FQN without leading forward slash.
Fixes #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants