New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support retrieving status and configuration of feed triggers #80
Conversation
Code changes LGTM with the following additions...
|
@jthomas yes, this is a WIP. work on the integration tests is needed. i've already modified the readme as follows
i think it best to match the pattern that is here. i.e., when the
section to be
and remove the
and then change the delete resource section to look like
|
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 99.41% 99.41% +<.01%
==========================================
Files 14 14
Lines 339 340 +1
==========================================
+ Hits 337 338 +1
Misses 2 2
Continue to review full report at Codecov.
|
@jthomas i've added to the integration test. mind having another look at this? |
@abaruni Code LGTM, still need the README.md changes? Your suggestions above about the doc structure make sense. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is to add support for retrieving the status and configuration of a feed trigger
Support has been implemented in the feed providers with the following:
apache/openwhisk-package-kafka#217 <-- Merged
apache/openwhisk-package-cloudant#137 <-- Merged
apache/openwhisk-package-alarms#101 <-- Merged