Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add possibility to use external redis #502

Merged
merged 3 commits into from
Jul 31, 2019
Merged

feat: add possibility to use external redis #502

merged 3 commits into from
Jul 31, 2019

Conversation

23doors
Copy link
Contributor

@23doors 23doors commented Jul 30, 2019

No description provided.

dgrove-oss
dgrove-oss requested changes Jul 31, 2019
View reviewed changes
Copy link
Member

@dgrove-oss dgrove-oss left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the one typo in configurationChoices.md

docs/configurationChoices.md Outdated Show resolved Hide resolved
dgrove-oss
dgrove-oss approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice addition! I will merge once travis passes the typo fix...

@dgrove-oss dgrove-oss self-assigned this Jul 31, 2019
@dgrove-oss dgrove-oss merged commit 08079e6 into apache:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss approved these changes

Assignees

@dgrove-oss dgrove-oss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@23doors @dgrove-oss