Add worker&host to logging #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this breaks the kibana query for the |
|
Please see the expected format comment: https://github.com/apache/incubator-openwhisk-package-alarms/blob/7923ba53764524967a8000b9fb7cf7e527b23490/provider/Logger.js#L41 |
|
I would recommend you put this information in the message if you need it. I personally name my container name in a way that gives me the worker and host. |
|
@jasonpet I think it is good to include workers and hosts in the logs explicitly because they are very important concepts. What do you think? |
|
yeah, I definitely agree that they are important for anyone using the HA support for alarms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We transmit logs to external platform and from there we check logs, but there is no host&worker information in the logs.
If the log contains host information, it is possible to detect duplicate active hosts with logs.
So I changed the log format.