Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license_compliance.md excludes "Gradle files" but rationale not sound #131

Closed
mrutkows opened this issue Apr 27, 2018 · 4 comments
Closed

Comments

@mrutkows
Copy link
Contributor

In the exclusion table allows for "Gradle files" not having ASF headers; however, the rationale is simple "not much IP" which is not sound logic since we enforce license in Bash and make files whose files have an equal amount of functional logic.

We wither need to explain better or enforce ASF license on gradle files where possible, that is for example on (gradlew.bat, build, gradle and gradlew):

Note that ASF license scanning (scancode may need to be updated if we decide to add.

@mrutkows
Copy link
Contributor Author

and "settings.gradle" as well.

@daisy-ycguo
Copy link
Member

and the folder "gradle" including:

  • gradle/docker.gradle
  • gradle/wrapper/gradle-wrapper.properties

My option is to add headers to build.gradle and settings.gradle, and ignore other gradle files, because

  • gradlew.bat and gradlew are similar in all repositories. There is not many differences among them.
  • gradle/docker.gradle are similar.
  • gradle/wrapper/gradle-wrapper.properties is property file

@houshengbo please comments. Thanks.

@houshengbo
Copy link

houshengbo commented May 8, 2018

@daisy-ycguo @mrutkows I lean on to not add license header to gradlew.bat and gradlew, because they are generated br gradle wrapper and may vary in different versions of gradle wrapper. They are not what we developed, but generated.

For build.gradle and settings.gradle, we can add license headers.

@mrutkows
Copy link
Contributor Author

Agree to close this as long as we add license to *.gradle config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants