Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify we do not include any tooling dot . configuration files in source release #161

Closed
mrutkows opened this issue May 23, 2018 · 4 comments

Comments

@mrutkows
Copy link
Contributor

Please make sure we do not include the following files which are for config. tooling:

.bin
.dockerignore
.git
.gitattributes
.github
.gitignore
.jshintrc
.pydevproject
.rat-excludes

or similar files prefixed with a dor . character.

@mrutkows
Copy link
Contributor Author

mrutkows commented May 30, 2018

@houshengbo Can we confirm that all TAR files we produce for source release have their "dot" configuration files and tooling directories deleted from final packaging?

@mrutkows
Copy link
Contributor Author

@houshengbo if you have confirmed this by inspection of a TARs you generated for the repos. then feel free to close this issue. I would appreciate a link to the PR (and file) where you fixed (and configured) this.

@houshengbo
Copy link

houshengbo commented Jun 11, 2018

@mrutkows .dockerignore has to stay, because we need to build the docker images locally based on it to determine what are copied into the images.

PR to fix this issue:
#182

@houshengbo
Copy link

This issue is closed, since #182 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants