Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wskdeploy -p finds manifest.yaml, but not manifest.yml #295

Closed
mrutkows opened this issue Jul 19, 2017 · 2 comments
Closed

wskdeploy -p finds manifest.yaml, but not manifest.yml #295

mrutkows opened this issue Jul 19, 2017 · 2 comments
Assignees

Comments

@mrutkows
Copy link
Contributor

The default behavior for wskdeploy when pointed to a Package directory is to look for the file "manifest.yaml"; however, our own "usecases" name the file "manifest.yml" (i.e., .yml versus .yaml) and fail.

Please allow the code to look for both .yaml and .yml extensions by default.

For example, our test (usecase) for webhook has instructions:

wskdeploy -p /tests/usecases/webhook

However, this fails with:

2017/07/19 08:33:22 missing manifest.yaml file

because the Manifest file is actually named "manifest.yml"

@mrutkows mrutkows changed the title wskdeploy default finds manifest.yaml, but not manifest.yml wskdeploy -p finds manifest.yaml, but not manifest.yml Jul 19, 2017
@lzbj
Copy link
Contributor

lzbj commented Jul 21, 2017

https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/deployers/shared.go, seems all the file extension was covered.

Will take a look in the code logic to handle the parameters.

@lzbj
Copy link
Contributor

lzbj commented Aug 9, 2017

#310

@lzbj lzbj closed this as completed Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants