Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate interactive mode in wskdeploy #758

Closed
pritidesai opened this issue Feb 26, 2018 · 4 comments
Closed

Deprecate interactive mode in wskdeploy #758

pritidesai opened this issue Feb 26, 2018 · 4 comments
Assignees

Comments

@pritidesai
Copy link
Member

We started Whisk Deploy with interactive mode a year back but now, we have come long way from prototyping mode to running in production. As of now, we have no use case for Interactive mode, so from code maintenance perspective, we have decided to deprecate and remove support for interactive mode from Whisk Deploy.

@csantanapr
Copy link
Member

+1

@mrutkows
Copy link
Contributor

@csantanapr already gutted 90% of this... the only part left is "report" which we plan to perhaps preserve as part of a "verify" step

@mrutkows
Copy link
Contributor

@pritidesai we will preserve the interactive flag as a means to stop/verify assets before deployment

@pritidesai
Copy link
Member Author

pritidesai commented Feb 27, 2018

sure @mrutkows we can, in that case, can we rename --allow-interactive and -i to --dryrun (as per @lionelvillard's suggestion)?

Also, there are some code paths we need to delete specially in whiskclient:

grep -r "interactive" .
./deployers/whiskclient.go:// (5) prompt for values in interactive mode if any of them are missing
./deployers/whiskclient.go:     // If we still can not find the values we need, check if it is interactive mode.
./deployers/whiskclient_test.go:        assert.Nil(t, err, "Failed to read credentials in interactive mode")
./parsers/manifest_parser.go:                   // TODO() interactive ask for branch, AND consider YAML specification to allow key for branch
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants