Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoker command line support for dynamicId assignment #2872

Closed
dgrove-oss opened this issue Oct 18, 2017 · 3 comments
Closed

invoker command line support for dynamicId assignment #2872

dgrove-oss opened this issue Oct 18, 2017 · 3 comments

Comments

@dgrove-oss
Copy link
Member

As discussed in the review of #2689, for Mesos it is not feasible to use environment variables to communicate the unique invoker names. For Mesos, we need to also support command-line flags style of specifying arguments. For example:
--name <some_name> --id <proposed_id>
For Kubernetes, we really would prefer environment variables.

So, the plan is to support both options. Add flags-style command line argument processing to the invoker and read the environment if explicit command lines are not provided.

@dgrove-oss
Copy link
Member Author

Please label as enhancement and assign to me. I plan to work on this next week.

@dgrove-oss
Copy link
Member Author

Implemented in PR #2939

@dgrove-oss
Copy link
Member Author

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants