Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed all .scala and .java files to ASF license headers. #2367

Merged
merged 1 commit into from Jun 20, 2017
Merged

Changed all .scala and .java files to ASF license headers. #2367

merged 1 commit into from Jun 20, 2017

Conversation

mrutkows
Copy link
Contributor

Updated all .scala files in all dirs. to the ASF approved header. In addition, found a handful of .java files and updated similarly.

@mrutkows mrutkows self-assigned this Jun 13, 2017
@rabbah rabbah added apache review Review for this PR has been requested and yet needs to be done. labels Jun 13, 2017
@markusthoemmes
Copy link
Contributor

Can we take out scancode validation of the old header to make sure we haven't forgotten any files?

@mrutkows
Copy link
Contributor Author

mrutkows commented Jun 14, 2017

@markusthoemmes was going to remove the IBM header in a separate "phase" once all repos. were similarly updated. Phase 1 is pointing this repo. (and others that currently scan) to the version in "utils" ... #2365 "Reference scancode from utils repo. but preserve local copy (phase 1)"

and was being cautious in this PR as to to easily see that all the 225 files only had header/comment changes. This also follows Carlos' advice given in another PR when we tried to remove local scancode previously (to instead go in phases).

Opened the following issue in utils to track Phase 2 removal of local scancode and Phase 3 removal of IBM headers:
#2376 "Phase 2: Remove scancode from openwhisk repo." and apache/openwhisk-utilities#10 "Phase 3: Remove IBM license header"

@mrutkows
Copy link
Contributor Author

@csantanapr @markusthoemmes Can we accept simply changing the headers here in this repo. to ASF as we have other issues (and a PR for pointing to new scancode) to remove IBM header (as a valid scan for all repos.) as part of phase 3?

Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good step towards changing all the headers. PR #2376 will take care of checking that IBM is not present

@csantanapr csantanapr merged commit 37bf7bf into apache:master Jun 20, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Jun 23, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Jun 23, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Jun 23, 2017
jonpspri pushed a commit to jonpspri/openwhisk that referenced this pull request Jul 4, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Jul 17, 2017
@mrutkows mrutkows deleted the asf-headers-scala branch July 20, 2017 19:35
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Jul 21, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Nov 13, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Nov 13, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Nov 13, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Nov 13, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Nov 14, 2017
houshengbo pushed a commit to houshengbo/openwhisk that referenced this pull request Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apache review Review for this PR has been requested and yet needs to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants