New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed all .scala and .java files to ASF license headers. #2367
Conversation
Can we take out scancode validation of the old header to make sure we haven't forgotten any files? |
@markusthoemmes was going to remove the IBM header in a separate "phase" once all repos. were similarly updated. Phase 1 is pointing this repo. (and others that currently scan) to the version in "utils" ... #2365 "Reference scancode from utils repo. but preserve local copy (phase 1)" and was being cautious in this PR as to to easily see that all the 225 files only had header/comment changes. This also follows Carlos' advice given in another PR when we tried to remove local scancode previously (to instead go in phases). Opened the following issue in utils to track Phase 2 removal of local scancode and Phase 3 removal of IBM headers: |
@csantanapr @markusthoemmes Can we accept simply changing the headers here in this repo. to ASF as we have other issues (and a PR for pointing to new scancode) to remove IBM header (as a valid scan for all repos.) as part of phase 3? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good step towards changing all the headers. PR #2376 will take care of checking that IBM is not present
Updated all .scala files in all dirs. to the ASF approved header. In addition, found a handful of .java files and updated similarly.