Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2862] Get protocol from client config base url #2909

Closed
wants to merge 1 commit into from
Closed

[2862] Get protocol from client config base url #2909

wants to merge 1 commit into from

Conversation

jsanda
Copy link
Contributor

@jsanda jsanda commented Oct 28, 2017

This PR is for issue 2862.

@rabbah
Copy link
Member

rabbah commented Oct 28, 2017

@mdeuser can you also review this?
Thanks John for the pr.

@jsanda
Copy link
Contributor Author

jsanda commented Oct 28, 2017

I have not done much programming with Go. I primarily use IntelliJ but decided to use emacs for Go. I have it set up to run gofmt on file save. I learned that gofmt uses hard tabs instead of spaces. I posted a question on the mailing list about style guidelines. I can push another commit that reverts the formatting. My only change is on line 821 from:

api.Action.BackendUrl = "https://" + Client.Config.Host + "/api/v1/web/" + qName.GetNamespace() + "/" + urlActionPackage + "/" + qName.GetEntity() + ".http"

to:
api.Action.BackendUrl = Client.Config.BaseUrl.Scheme + "://" + Client.Config.Host + "/api/v1/web/" + qName.GetNamespace() + "/" + urlActionPackage + "/" + qName.GetEntity() + ".http"

@jsanda jsanda closed this Oct 28, 2017
@jsanda jsanda reopened this Oct 28, 2017
@jsanda jsanda closed this Oct 28, 2017
@csantanapr
Copy link
Member

Hi John thanks for the PR no need to close the PR the fix looks good It's just a matter or getting scancode happy
This is a tool we use in our repos you can configure it as a git pre-commit hook following the steps here https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines

@jsanda
Copy link
Contributor Author

jsanda commented Oct 28, 2017

I reverted the commit and github automatically closed the PR. PR 2910 replaces this one.

Thanks for the link about the pre-commit hook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants