Change recently added metric key name. (very simple change) #3265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #2968(merged 2days ago) and thank you for your commit @mhenke1
I think it is more common to use dotted notation format(.) for recording metric.
Most time series db like Graphite, OpenTSDB and InfluxDB normally use a dot-delimited notation. (e.g.
sys.cpu.user
,invoker_docker.rm_start
)Even in the openwhisk code, metric keys for recording docker cmd use dot delimiter.
If you are using kamon-statsd with graphite, a query is a better way.
For example, a query like
invoker_containerStart.prewarmed.*
will fill the variable with all possible values that exist in the wildcard positionBefore
After
And I also changed naming convention,
because most of the metric key names already used in the code is using camelcase like
activationRun
,invokerOffline
andblockingActivation
,