Check all testfiles to actually contain the RunWith annotation.
#3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusthoemmes
added
review
markusthoemmes
changed the title
RunWith annotation.RunWith annotation.
markusthoemmes
force-pushed
the
lint-tests
branch
from
0d44849
to
b571afb
Compare
We had a couple of rogue tests in the repository which didn't have the annotation `RunWith`, so they haven't been run in CI/CD at all.
markusthoemmes
force-pushed
the
lint-tests
branch
from
86d2991
to
f8406c2
Compare
markusthoemmes
changed the title
RunWith annotation.RunWith annotation.
|
PG2 2823 🔵 |
|
Oh my 😱 Good find @markusthoemmes @cbickel 👍 |
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
…ache#3290) We had a couple of rogue tests in the repository which didn't have the annotation `RunWith`, so they haven't been run in CI/CD at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a couple of rogue tests in the repository which didn't have the annotation
RunWith, so they haven't been run in CI/CD at all.Note: Misses one file on purpose to test the fail.