Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the license and notice for ConcurrentMapBackedCache.scala #3703

Merged
merged 1 commit into from May 30, 2018

Conversation

houshengbo
Copy link

@houshengbo houshengbo commented May 24, 2018

The source code file called ConcurrentMapBackedCache.scala uses the source
code of Spray.

Closes: apache/openwhisk-release#152

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@houshengbo houshengbo added the wip label May 24, 2018
@houshengbo houshengbo force-pushed the fix-lightbend-copyright branch 3 times, most recently from 8ba5a42 to cc695a5 Compare May 24, 2018 18:53
@codecov-io
Copy link

codecov-io commented May 24, 2018

Codecov Report

Merging #3703 into master will increase coverage by 0.96%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3703      +/-   ##
==========================================
+ Coverage   74.06%   75.02%   +0.96%     
==========================================
  Files         126      127       +1     
  Lines        6030     6030              
  Branches      388      388              
==========================================
+ Hits         4466     4524      +58     
+ Misses       1564     1506      -58
Impacted Files Coverage Δ
...re/database/MultipleReadersSingleWriterCache.scala 95.83% <ø> (+1%) ⬆️
...whisk/core/database/ConcurrentMapBackedCache.scala 90% <90%> (ø)
...cala/src/main/scala/whisk/http/ErrorResponse.scala 89.77% <0%> (+1.13%) ⬆️
...on/scala/src/main/scala/whisk/common/Logging.scala 87.35% <0%> (+1.14%) ⬆️
...ain/scala/whisk/core/entity/ActivationResult.scala 92.3% <0%> (+1.53%) ⬆️
...rc/main/scala/whisk/common/ForcableSemaphore.scala 88.46% <0%> (+3.84%) ⬆️
...in/scala/whisk/utils/ExecutionContextFactory.scala 100% <0%> (+7.69%) ⬆️
...rc/main/scala/whisk/core/entity/ExecManifest.scala 96.1% <0%> (+15.58%) ⬆️
...whisk/connector/kafka/KafkaConsumerConnector.scala 58.33% <0%> (+22.91%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d22b99...8071507. Read the comment docs.

@houshengbo houshengbo force-pushed the fix-lightbend-copyright branch 5 times, most recently from b93e83c to 35a354f Compare May 25, 2018 19:24
@houshengbo houshengbo removed the wip label May 25, 2018
@houshengbo houshengbo force-pushed the fix-lightbend-copyright branch 2 times, most recently from a7a78e8 to 5392044 Compare May 25, 2018 19:33
The source code file called ConcurrentMapBackedCache.scala uses the source
code of Spray.

Closes: apache/openwhisk-release#152
Copy link
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo thanks for running a PG as asked; you may want to include the number in the comments.

@houshengbo
Copy link
Author

Playground4/1758/ passed.

BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
…#3703)

The source code file called ConcurrentMapBackedCache.scala uses the source
code of Spray.

Closes: apache/openwhisk-release#152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightbend copyright appears, no LICENSE attribution
3 participants