Fix warnings in python scripts. #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusthoemmes
added
the
review
Codecov Report
@@ Coverage Diff @@
## master #3874 +/- ##
==========================================
- Coverage 75.56% 70.78% -4.79%
==========================================
Files 145 145
Lines 6896 6896
Branches 426 426
==========================================
- Hits 5211 4881 -330
- Misses 1685 2015 +330
Continue to review full report at Codecov.
|
rabbah
approved these changes
Jul 13, 2018
| @@ -278,12 +278,12 @@ Components = [ | |||
| 'build a runtime action container, matching name using the regex; NOTE: must use --dir for path to runtime directory', | |||
| yaml = False, | |||
| gradle = 'core:$1:distDocker'), | |||
|
|
|||
There was a problem hiding this comment.
how did these sneak in here with scancode anyway!?
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
* Fix Flake8 warnings. * Enable Flake8 to abort the build even on warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title.
Also enabled Flake8 to exit non-zero if there are warnings, seems like there is no harm to that right now. We can always disable that again if it really gets in the way.