update mesos-actor; cleanup orphaned failed task launches #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysonnorris
force-pushed
the
mesos-task-cleanup
branch
from
eadeda0
to
b3435e8
Compare
chetanmeh
reviewed
Nov 13, 2018
| MetricEmitter.emitCounterMetric(LoggingMarkers.INVOKER_MESOS_CMD_TIMEOUT(MesosTask.KILL_CMD)) | ||
| case Failure(t) => transid.failed(this, start, s"task destroy failed ${t.getMessage}", ErrorLevel) | ||
| } | ||
| .map(_ => {})(ec) |
There was a problem hiding this comment.
ec is implicitly available so we can drop passing it explicitly.
| destroy(mesosClientActor, mesosConfig, taskId) | ||
| case Failure(t) => | ||
| //kill the task whose launch timed out | ||
| destroy(mesosClientActor, mesosConfig, taskId) |
There was a problem hiding this comment.
Note that the future returned by destroy for andThen call would be discarded so its more like ask and forget here. Is that the intention or it would be better to have destroy completed by the time creates resulting future completes?
There was a problem hiding this comment.
In this case destroy is just cleanup that is mesos-specific, so it should happen independent of the create future; i.e. create() timeout should return immediately, but trigger the cleanup of destroy()
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
update mesos-actor and cleanup orphaned failed task launches * review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When task launch times out, cleanup tasks that were sent to mesos (or not yet sent).
Also updating mesos-actor which includes a fix for accepting resources that are not assigned to the frameworks role.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: