Do not link the /run/runc volume unless invoker_use_runc is set

[akrabat]

On Mac, /run/runc doesn't exist and trying to set it as a volume causes an error.

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• [x ] Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• [x ] I signed an Apache CLA.
• [x ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[dubee]

Ran into this problem when using the latest Docker for Mac. Thanks for the fix!

[rabbah]

LGTM

[mhenke1]

invoker_use_runcis not reachable here.
it probably should be when: invoker.useRunc

[akrabat]

Thanks. Updated.

[codecov-io]

Codecov Report

Merging #4149 into master will decrease coverage by 3.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4149      +/-   ##
==========================================
- Coverage   84.74%   80.77%   -3.97%     
==========================================
  Files         151      152       +1     
  Lines        7277     7450     +173     
  Branches      466      487      +21     
==========================================
- Hits         6167     6018     -149     
- Misses       1110     1432     +322

Impacted Files	Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala	0% <0%> (-100%)	⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala	0% <0%> (-95.54%)	⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala	0% <0%> (-92.6%)	⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala	0% <0%> (-83.34%)	⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala	0% <0%> (-62.5%)	⬇️
...in/scala/org/apache/openwhisk/common/Counter.scala	40% <0%> (-20%)	⬇️
...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala	92% <0%> (-4%)	⬇️
...apache/openwhisk/core/entitlement/Collection.scala	83.67% <0%> (-3.51%)	⬇️
...e/loadBalancer/ShardingContainerPoolBalancer.scala	82.79% <0%> (-2.31%)	⬇️
...org/apache/openwhisk/core/controller/Actions.scala	91.48% <0%> (-0.18%)	⬇️
... and 23 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a790bb8...c907c5b. Read the comment docs.

[akrabat]

Travis passed! 🎉

[mhenke1]

And it worked for me too.I would be happy to see this merged soon.

[dgrove-oss]

PG3 3124 🏃

[dgrove-oss]

PG3 3124 👍 -- 4 unrelated failures, otherwise good.