Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 7.3 runtime #4182

Merged
merged 3 commits into from Dec 17, 2018
Merged

Add PHP 7.3 runtime #4182

merged 3 commits into from Dec 17, 2018

Conversation

akrabat
Copy link
Member

@akrabat akrabat commented Dec 16, 2018

Add support for the new PHP 7.3 runtime.

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

docs/actions-php.md Outdated Show resolved Hide resolved
@rabbah
Copy link
Member

rabbah commented Dec 16, 2018

@akrabat
Copy link
Member Author

akrabat commented Dec 16, 2018

Added to swagger. Thanks @rabbah.

Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- guzzlehttp/guzzle
- ramsey/uuid

The specific versions of these packages depends on the PHP runtime in use and is listed in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The specific versions of these packages depends on the PHP runtime in use and is listed in the
The specific versions of these packages depends on the PHP runtime in use and is listed in the

remove trailing space

@codecov-io
Copy link

Codecov Report

Merging #4182 into master will decrease coverage by 4.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4182      +/-   ##
==========================================
- Coverage   86.03%   81.18%   -4.86%     
==========================================
  Files         152      152              
  Lines        7292     7292              
  Branches      472      472              
==========================================
- Hits         6274     5920     -354     
- Misses       1018     1372     +354
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-95.54%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-92.6%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-83.34%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 0% <0%> (-62.5%) ⬇️
...in/scala/org/apache/openwhisk/common/Counter.scala 40% <0%> (-20%) ⬇️
...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala 92% <0%> (-4%) ⬇️
...rg/apache/openwhisk/common/ForcibleSemaphore.scala 92.3% <0%> (-3.85%) ⬇️
...whisk/connector/kafka/KafkaConsumerConnector.scala 61.19% <0%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780c98c...6a7ae6d. Read the comment docs.

@csantanapr csantanapr merged commit 053bd9a into apache:master Dec 17, 2018
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants