Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize Invocations per Minute limit #4207

Closed
wants to merge 1 commit into from

Conversation

jonpspri
Copy link
Contributor

@jonpspri jonpspri commented Jan 7, 2019

On faster Travis machines, the System Test fails because it runs into the Invoker's Invocations Per Minute limit. While this is a Good Thing in general, it's quite frustrating during a system test. This PR adds parameterization of the Invocations Per Minute limit to the test scripts so that the system test can raise that limit and avoid spurious failures.

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

ROOTDIR="$SCRIPTDIR/../.."

cd $ROOTDIR/tools/travis

export ORG_GRADLE_PROJECT_testSetName="REQUIRE_SYSTEM"
export GRADLE_COVERAGE=true

./setupPrereq.sh /ansible/files/runtimes-nodeonly.json
./setupPrereq.sh /ansible/files/runtimes-nodeonly.json 240
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current default is 60 - won't setting this to 240 cause any tests that might rely on 60 to fail?
When does travis run on 'faster' machines? Is there an example failure at https://travis-ci.org/apache/incubator-openwhisk/?

$ANSIBLE_CMD properties.yml -e manifest_file="$RUNTIMES_MANIFEST"
$ANSIBLE_CMD properties.yml \
-e "{ \"manifest_file\": \"$RUNTIMES_MANIFEST\",
\"invoker_use_runc\": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is invoker_use_runc required here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont see why runc should be in here either.

@rabbah
Copy link
Member

rabbah commented Jan 26, 2019

Thanks @tysonnorris for reviewing this.
@jonpspri is there a particular suite that fails? There is a throttle settling pattern we've used inter-suite and intra-suite. Generally I'm OK bumping this limit in paramaterized way although there are actually throttle tests that depend on these limits.

@rabbah rabbah added testing awaits-contributor The contributor needs to respond to comments from reviewer. labels Feb 9, 2019
@jonpspri jonpspri closed this Apr 19, 2020
@jonpspri jonpspri deleted the pr-limits-ipm branch April 19, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-contributor The contributor needs to respond to comments from reviewer. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants