preload: strip existing rel=preload hints

Fixes #1327
apache · Jul 13, 2016 · dbde989 · dbde989
1 parent 19cf3bb
commit dbde989
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/net/instaweb/rewriter/strip_subresource_hints_filter.cc b/net/instaweb/rewriter/strip_subresource_hints_filter.cc
@@ -51,7 +51,9 @@ void StripSubresourceHintsFilter::StartElement(HtmlElement* element) {
 
   if (element->keyword() == HtmlName::kLink) {
     const char *value = element->AttributeValue(HtmlName::kRel);
-    if (value && StringCaseEqual(value, "subresource")) {
+    if (value && (
+            StringCaseEqual(value, "subresource") ||
+            StringCaseEqual(value, "preload"))) {
       const RewriteOptions *options = driver_->options();
       const char *resource_url = element->AttributeValue(HtmlName::kSrc);
       if (!resource_url) {

diff --git a/net/instaweb/rewriter/strip_subresource_hints_filter_test.cc b/net/instaweb/rewriter/strip_subresource_hints_filter_test.cc
@@ -156,6 +156,16 @@ TEST_F(StripSubresourceHintsFilterTest, SingleResourceValidLink) {
   ValidateStripSubresourceHint(source, rewritten);
 }
 
+TEST_F(StripSubresourceHintsFilterTest, SingleResourceValidPreloadLink) {
+  const char *source =
+    "<head><link rel=\"preload\" src=\"/test.gif\" as=\"image\"/></head>"
+    "<body><img src=\"1.jpg\"/></body>";
+  const char *rewritten =
+    "<head></head>"
+    "<body><img src=\"1.jpg\"/></body>";
+  ValidateStripSubresourceHint(source, rewritten);
+}
+
 TEST_F(StripSubresourceHintsFilterTest, SingleResourceExternalLink) {
   const char *source =
     "<head>"