Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

LocalStorageCache filter doesn't handle QuotaExceededError #1275

Open
deweydb opened this issue Mar 3, 2016 · 3 comments
Open

LocalStorageCache filter doesn't handle QuotaExceededError #1275

deweydb opened this issue Mar 3, 2016 · 3 comments

Comments

@deweydb
Copy link

deweydb commented Mar 3, 2016

I'm getting quota exceeded errors client side while running ngx_pagespeed module.
Uncaught QuotaExceededError: Failed to execute 'setItem' on 'Storage': Setting the value of 'pagespeed_lsc_url:https://bid13.com/sites/default/files/imagecache/product_list/19-1_0.jpg pagespeed_lsc_hash:FceD9qKAq8' exceeded the quota.

This error occurs in chrome (Version 48.0.2564.116 (64-bit) on this page: https://bid13.com

Please let me know if i can provide any further information.

@jeffkaufman
Copy link
Contributor

It sounds to me like you enabled the local storage caching filter [1] and you have enough images that you hit Chrome's quota?

This isn't a problem by itself, but you could consider turning off the filter.

[1] https://developers.google.com/speed/pagespeed/module/filter-local-storage-cache

@deweydb
Copy link
Author

deweydb commented Mar 7, 2016

Yeah i disabled the filter for now. it would be nice if i could leave it enabled and there was some sort of check for amount of storage space so errors like this didn't occur.

@jeffkaufman jeffkaufman changed the title QuotaExceededError: Failed to execute 'setItem' on 'Storage' ... LocalStorageCache filter doesn't handle QuotaExceededError Mar 7, 2016
@jeffkaufman
Copy link
Contributor

It sounds like at the least we should be catching this error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants