New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline_import_to_link should handle multiple @import statements #491

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

Currently, inline_import_to_link will transform style tags with exactly one 
@import to a link.

It should be updated to transform style tags with multiple @import statements 
to multiple links.

Original issue reported on code.google.com by jmara...@google.com on 11 Sep 2012 at 3:07

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Here's an example from bostonherald.com

<style type="text/css" title="currentStyle" media="screen">
   @import "http://cache.heraldinteractive.com/CSS/version5.0/universal.css?63310";
       @import "http://cache.heraldinteractive.com/CSS/version5.0/navigation_beta.css?123";
   @import "http://cache.heraldinteractive.com/CSS/version5.0/navigation.css?321";
   @import "http://cache.heraldinteractive.com/CSS/version5.0/teases.css";
   @import "http://cache.heraldinteractive.com/CSS/version5.0/homepage.css?nocache=987";
   @import "http://cache.heraldinteractive.com/CSS/version5.0/yourPicks.css?nocache=123";
   @import "http://cache.heraldinteractive.com/CSS/version5.0/sportsTabsHomepage.css";
   @import "http://cache.heraldinteractive.com/CSS/version5.0/businessTabsHomepage.css";
   @import "http://cache.heraldinteractive.com/CSS/version5.0/slider.css?09";
   @import "http://cache.heraldinteractive.com/CSS/version5.0/weather.css";
  @import "http://cache.heraldinteractive.com/CSS/version5.0/style3.css";
  @import "http://cache.heraldinteractive.com/CSS/version5.0/style3_tmp.css";
   </style>

Original comment by jmara...@google.com on 11 Sep 2012 at 3:09

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

is this done?

Original comment by jmara...@google.com on 28 Sep 2012 at 8:18

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Will appear in 0.10.22.8.

Original comment by matterb...@google.com on 28 Sep 2012 at 8:19

  • Changed state: Fixed
  • Added labels: Milestone-v23, release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment