Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

ModifyCachingHeaders should not touch Cache-Control headers if downstream-caching is enabled. #756

GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments


Copy link

Current behavior:
ModifyCachingHeaders is on by default, and will change all HTML to have 
no-cache Cache-Control headers.
Downstream-caching documentation 
recommends specifying "ModifyCachingHeaders off" so that the downstream cache 
(e.g. varnish) gets access to the origin-server's Cache-control headers for 
HTML, which possibly involve non-zero max-age values. Downstream caches can 
then respect these values wrt caching in their layer, but should carefully 
change these to no-cache on their way out. We also recommend that Etag and 
Last-Modified headers be stripped in the caching layer.

Suggested behavior:
ModifyCachingHeaders should remain on by default. If downstream-caching is 
enabled, we (PSOL) should not touch the "Cache-Control" header but handle all 
other caching-related headers (e.g. Last-Modified, Etag) as before. This will 
ensure that the feature works correctly (and somewhat transparently) with 
downstream-caching and also result in fewer caching-layer-directives in our 

Original issue reported on by on 30 Jul 2013 at 4:34

Copy link

Fixed in

Original comment by on 30 Oct 2013 at 2:47

  • Changed state: Fixed

Copy link

Original comment by on 31 Oct 2013 at 5:46

  • Added labels: Milestone-v30, release-note

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

No branches or pull requests

1 participant