New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModifyCachingHeaders should not touch Cache-Control headers if downstream-caching is enabled. #756

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

Current behavior:
ModifyCachingHeaders is on by default, and will change all HTML to have 
no-cache Cache-Control headers.
Downstream-caching documentation 
(https://developers.google.com/speed/pagespeed/module/downstream-caching) 
recommends specifying "ModifyCachingHeaders off" so that the downstream cache 
(e.g. varnish) gets access to the origin-server's Cache-control headers for 
HTML, which possibly involve non-zero max-age values. Downstream caches can 
then respect these values wrt caching in their layer, but should carefully 
change these to no-cache on their way out. We also recommend that Etag and 
Last-Modified headers be stripped in the caching layer.

Suggested behavior:
ModifyCachingHeaders should remain on by default. If downstream-caching is 
enabled, we (PSOL) should not touch the "Cache-Control" header but handle all 
other caching-related headers (e.g. Last-Modified, Etag) as before. This will 
ensure that the feature works correctly (and somewhat transparently) with 
downstream-caching and also result in fewer caching-layer-directives in our 
recommendation.

Original issue reported on code.google.com by anup...@google.com on 30 Jul 2013 at 4:34

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Fixed in https://code.google.com/p/modpagespeed/source/detail?r=3585

Original comment by anup...@google.com on 30 Oct 2013 at 2:47

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by hui...@google.com on 31 Oct 2013 at 5:46

  • Added labels: Milestone-v30, release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment