Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

base URL not respected for image rewriting #94

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments
Closed

base URL not respected for image rewriting #94

GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

From issue 43:

My <header>..</head> contains

<base href="http://www.sellmyretro.com/" />

The site logo was then being loaded with:
<img src="uploaded/img/site-logo.gif" />

I wonder if mod_pagespeed was not taking account of the base href to find the 
site logo?
I replaced this with a simple:
<img src="/uploaded/img/site-logo.gif" />

and it worked.  However, mod_pagespeed should take accout of the base href 
directive.

Original issue reported on code.google.com by sligocki@google.com on 17 Nov 2010 at 3:20

@GoogleCodeExporter
Copy link
Author

We intend to respect base URLs, but that support was added pretty recently and 
might be a little spotty, I'll take a look.

Original comment by sligocki@google.com on 17 Nov 2010 at 3:22

@GoogleCodeExporter
Copy link
Author

Hm, I added a test and ImageRewriteFilter seems to be respecting base URL, can 
you send me an example that fails? Thanks.

Original comment by sligocki@google.com on 18 Nov 2010 at 12:34

@GoogleCodeExporter
Copy link
Author

It seems to be working in the latest version of mod_pagespeed so would suggest 
this issue is closed unless anyone else notices it.

Original comment by rwap.services on 18 Nov 2010 at 10:33

@GoogleCodeExporter
Copy link
Author

Great, glad to hear it.

Original comment by sligocki@google.com on 18 Nov 2010 at 3:41

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant