New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base URL not respected for image rewriting #94

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

From issue 43:

My <header>..</head> contains

<base href="http://www.sellmyretro.com/" />

The site logo was then being loaded with:
<img src="uploaded/img/site-logo.gif" />

I wonder if mod_pagespeed was not taking account of the base href to find the 
site logo?
I replaced this with a simple:
<img src="/uploaded/img/site-logo.gif" />

and it worked.  However, mod_pagespeed should take accout of the base href 
directive.

Original issue reported on code.google.com by sligocki@google.com on 17 Nov 2010 at 3:20

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

We intend to respect base URLs, but that support was added pretty recently and 
might be a little spotty, I'll take a look.

Original comment by sligocki@google.com on 17 Nov 2010 at 3:22

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Hm, I added a test and ImageRewriteFilter seems to be respecting base URL, can 
you send me an example that fails? Thanks.

Original comment by sligocki@google.com on 18 Nov 2010 at 12:34

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

It seems to be working in the latest version of mod_pagespeed so would suggest 
this issue is closed unless anyone else notices it.

Original comment by rwap.services on 18 Nov 2010 at 10:33

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Great, glad to hear it.

Original comment by sligocki@google.com on 18 Nov 2010 at 3:41

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment