Fix issue with S3 FS not working with segments with spaces in the name #10055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10055 +/- ##
=============================================
+ Coverage 35.06% 70.39% +35.32%
- Complexity 200 5695 +5495
=============================================
Files 1995 1995
Lines 107593 107612 +19
Branches 16353 16359 +6
=============================================
+ Hits 37732 75754 +38022
+ Misses 66611 26555 -40056
- Partials 3250 5303 +2053
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
reviewed
Jan 4, 2023
| @@ -98,6 +98,8 @@ | |||
| */ | |||
| public abstract class SegmentDirectory implements Closeable { | |||
|
|
|||
| public abstract boolean isDirectoryMatchingWithLatestConfigs(); | |||
There was a problem hiding this comment.
What is this API stands for?
|
Can we also add a test to guard the behavior? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3PinotFS fails to process segments with spaces in their names. This is due to URI.getPath() returning decoded path while the
.prefixfunction expects unescaped path.