Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ControllerTest default prot to 18998 #4259

Merged
merged 1 commit into from May 31, 2019

Conversation

Jackie-Jiang
Copy link
Contributor

Port 8998 is commonly used, which might cause address already in use problem.
Change it to 18998 to avoid this.
Also remove redundant entries in gitignore.

Port 8998 is commonly used, which might cause address already in use problem.
Change it to 18998 to avoid this.
Also remove redundant entries in gitignore.
@codecov-io
Copy link

Codecov Report

Merging #4259 into master will increase coverage by 6.87%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4259      +/-   ##
============================================
+ Coverage     60.35%   67.23%   +6.87%     
  Complexity       20       20              
============================================
  Files          1165     1041     -124     
  Lines         58535    51534    -7001     
  Branches       8144     7220     -924     
============================================
- Hits          35329    34648     -681     
+ Misses        20764    14529    -6235     
+ Partials       2442     2357      -85
Impacted Files Coverage Δ Complexity Δ
...a/manager/realtime/RealtimeSegmentDataManager.java 50% <0%> (-50%) 0% <0%> (ø)
...pache/pinot/core/util/SortedRangeIntersection.java 83.82% <0%> (-7.36%) 0% <0%> (ø)
...e/operator/dociditerators/SortedDocIdIterator.java 55.55% <0%> (-2.78%) 0% <0%> (ø)
...g/apache/pinot/common/metrics/AbstractMetrics.java 76% <0%> (-1.34%) 0% <0%> (ø)
.../pinot/core/data/manager/BaseTableDataManager.java 92.68% <0%> (-1.22%) 0% <0%> (ø)
.../pinot/core/common/datatable/DataTableBuilder.java 78.94% <0%> (-1.17%) 0% <0%> (ø)
...core/query/executor/ServerQueryExecutorV1Impl.java 81.37% <0%> (-0.69%) 0% <0%> (ø)
...n/java/org/apache/pinot/tools/SegmentDumpTool.java
...segment/converter/PinotSegmentToJsonConverter.java
...ot/tools/query/comparison/SegmentInfoProvider.java
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7abfb12...9918487. Read the comment docs.

Copy link
Contributor

@jackjlli jackjlli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@Jackie-Jiang Jackie-Jiang merged commit d540d95 into master May 31, 2019
@Jackie-Jiang Jackie-Jiang deleted the change_controller_test_port branch May 31, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants