-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Vertica as data source #4404
Conversation
DataSource dataSource = new DataSource(); | ||
dataSource.setInitialSize(INIT_CONNECTIONS); | ||
dataSource.setMaxActive(MAX_CONNECTIONS); | ||
System.out.println(verticaUser); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove the print line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @jihaozh. I removed that line.
Removed one unwanted print line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding this. @tysaito
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for contributing!
I made changes by following https://thirdeye.readthedocs.io/en/latest/contribute_datasource.html. Please let me know if there are any more change which are required.