Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests for API resources to a different package #4415

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

Jackie-Jiang
Copy link
Contributor

To prevent the API application to load the test files which can cause class not found exception

To prevent the API application to load the test files which can cause class not found exception
Copy link
Contributor

@jackjlli jackjlli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e71ac1b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4415   +/-   ##
=========================================
  Coverage          ?   65.34%           
  Complexity        ?       20           
=========================================
  Files             ?     1068           
  Lines             ?    55557           
  Branches          ?     7910           
=========================================
  Hits              ?    36306           
  Misses            ?    16672           
  Partials          ?     2579
Impacted Files Coverage Δ Complexity Δ
...che/pinot/controller/api/resources/TableViews.java 91.3% <ø> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71ac1b...2f67b67. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit 07e2c72 into master Jul 10, 2019
@Jackie-Jiang Jackie-Jiang deleted the move_resources_test branch July 10, 2019 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants