Fix issue with PerfBenchmarkRunner where server can no longer pre-load segments from dataDir. #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjlli
approved these changes
May 20, 2020
mayankshriv
force-pushed
the
perf-runner
branch
2 times, most recently
from
434d07b
to
d5afd3d
Compare
…d segments from dataDir. Due to recent PRs (apache#5383, apache#5381), PerfBenchmarkRunner now makes additional copy of segments on controller, and makes server download data from controller. The original behavior was to bypass this and for servers to directly preload from disk. This PR is undoing the changes from above PR to get back to old behavior that is more optimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent PRs (#5383, #5381), PerfBenchmarkRunner now makes additional copy
of segments on controller, and makes server download data from controller.
The original behavior was to bypass this and for servers to directly preload
from disk. This PR is undoing the changes from above PR to get back to old
behavior that is more optimal.