Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TE] endpoints for alerts page filters #5432

Merged
merged 1 commit into from May 26, 2020
Merged

[TE] endpoints for alerts page filters #5432

merged 1 commit into from May 26, 2020

Conversation

jihaozh
Copy link
Member

@jihaozh jihaozh commented May 22, 2020

This PR adds the endpoints for the filters in the new alert list page.

  • Auto-complete for detections, subscription groups, applications, and alert owners.
  • Search for the alerts that are subscribed by a user.
  • The endpoints to return a list of all rules in the detection pipeline.

harleyjj
harleyjj approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@harleyjj harleyjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaohui-sun
xiaohui-sun approved these changes May 24, 2020
View reviewed changes
Copy link

@xiaohui-sun xiaohui-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jihaozh jihaozh merged commit 4270def into master May 26, 2020
@jihaozh jihaozh deleted the alerts-auto-complete branch May 26, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harleyjj harleyjj harleyjj approved these changes

@xiaohui-sun xiaohui-sun xiaohui-sun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jihaozh @harleyjj @xiaohui-sun