Change a NPE to have a better error message #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snleee
reviewed
Jun 8, 2020
| @@ -60,7 +60,11 @@ public ImmutableSegmentImpl(SegmentDirectory segmentDirectory, SegmentMetadataIm | |||
|
|
|||
| @Override | |||
| public Dictionary getDictionary(String column) { | |||
| return _indexContainerMap.get(column).getDictionary(); | |||
| ColumnIndexContainer container = _indexContainerMap.get(column); | |||
| if (container == null) { | |||
There was a problem hiding this comment.
Preconditions.checkNotNull(container, "Invalid column: " + column);
There was a problem hiding this comment.
@snleee, was in pending state for too many days. Better to get the functionality committed asap
Jackie-Jiang
reviewed
Jun 9, 2020
kishoreg
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve an error message when a table spec is missing a dimension that is specified in a star tree schema.
#5479