[Post-Aggregation] Support post-aggregation in ORDER-BY #5856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
post_aggregation_4
branch
from
3dd5cbe
to
c4c4a01
Compare
Jackie-Jiang
force-pushed
the
post_aggregation_4
branch
from
c4c4a01
to
75c686f
Compare
npawar
approved these changes
Aug 17, 2020
| * Helper method to construct a OrderByValueExtractor based on the given expression. | ||
| */ | ||
| private OrderByValueExtractor getOrderByValueExtractor(ExpressionContext expression) { | ||
| if (expression.getType() == ExpressionContext.Type.LITERAL) { |
There was a problem hiding this comment.
what does it mean to have ORDER BY a literal? can you give an example?
There was a problem hiding this comment.
Order-by with literal itself does not make a lot of sense, but post-aggregation might contain literal (e.g. ORDER BY SUM(col1) * 2 - SUM(col2))
| aggregationColumnToFunction.put(columnName, aggregationFunctions[i - numKeyColumns]); | ||
| } | ||
| List<ExpressionContext> groupByExpressions = queryContext.getGroupByExpressions(); | ||
| assert groupByExpressions != null; |
There was a problem hiding this comment.
why using assert instead of Preconditions.checkState?
There was a problem hiding this comment.
I usually use assert to indicate that the value is not possible to be null, which has zero run-time impact, and use checkState to verify certain states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance
TableResizerto support post-aggregation in ORDER-BY clause