Add HAVING support #5889
Merged
Add HAVING support #5889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
having_clause
branch
from
f287a70
to
fc8d3c4
Compare
Jackie-Jiang
commented
Aug 18, 2020
| for (int rowId = 0; rowId < numRows; rowId++) { | ||
| Object[] values = new Object[_numColumns]; | ||
| for (int colId = 0; colId < _numColumns; colId++) { | ||
| switch (columnDataTypes[colId]) { |
There was a problem hiding this comment.
NOTE: Change this to per-value switch based because we have found that this way has better performance (similar change in #4788 for performance improvement)
npawar
approved these changes
Aug 20, 2020
| case BYTES: | ||
| return _predicateEvaluator.applySV(((ByteArray) value).getBytes()); | ||
| default: | ||
| throw new IllegalStateException(); |
There was a problem hiding this comment.
It is not possible to run into this branch as the _valueType is set inside the class
| query = "SELECT COUNT(*) AS Count, DaysSinceEpoch FROM mytable GROUP BY DaysSinceEpoch HAVING Count > 350"; | ||
| testSqlQuery(query, Collections.singletonList(query)); | ||
| query = | ||
| "SELECT MAX(ArrDelay) - MAX(AirTime) AS Diff, DaysSinceEpoch FROM mytable GROUP BY DaysSinceEpoch HAVING Diff * 2 > 1000 ORDER BY Diff ASC"; |
There was a problem hiding this comment.
how about some queries with AND and OR RowMatchers as well?
Jackie-Jiang
force-pushed
the
having_clause
branch
from
fc8d3c4
to
a6adf75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for SQL HAVING clause
Example of supported query:
SELECT MAX(ArrDelay) - MAX(AirTime) AS Diff, DaysSinceEpoch FROM mytable GROUP BY DaysSinceEpoch HAVING Diff > 500 ORDER BY Diff ASC