Fixing S3PinotFS List API returned partial results #6002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
requested review from
KKcorps,
mayankshriv,
Jackie-Jiang and
kishoreg
kishoreg
approved these changes
Sep 11, 2020
...s/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java
Outdated
Show resolved
Hide resolved
|
We should also review other PinotFs implementations to ensure the similar issues are not presenting there. |
5 tasks
xiangfu0
force-pushed
the
fixing_s3_list_api
branch
from
8665918
to
0226925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
S3 API has a bounded limit(1000) for the objects returned in ListObject API, which means each call may at most returned 1000 S3 objects.
This PR will check
ListObjectsV2Responseand fetch next batch when necessary.AWS API Ref: https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html