Add a length limit of 512 to the properties stored in the segment metadata #6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
metadata_property_length_limit
branch
from
362fa39
to
5593656
Compare
Codecov Report
@@ Coverage Diff @@
## master #6008 +/- ##
===========================================
- Coverage 66.44% 46.34% -20.11%
===========================================
Files 1075 1180 +105
Lines 54773 55889 +1116
Branches 8168 8134 -34
===========================================
- Hits 36396 25899 -10497
- Misses 15700 27869 +12169
+ Partials 2677 2121 -556
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yupeng9
reviewed
Sep 11, 2020
| @@ -78,6 +78,9 @@ | |||
| public class SegmentColumnarIndexCreator implements SegmentCreator { | |||
| // TODO Refactor class name to match interface name | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(SegmentColumnarIndexCreator.class); | |||
| // Allow at most 512 characters for the metadata property | |||
| private static final int METADATA_PROPERTY_LENGTH_LIMIT = 512; | |||
There was a problem hiding this comment.
shall this align with FieldSpec.DEFAULT_MAX_LENGTH?
There was a problem hiding this comment.
They are independent, where the maxLength is configurable in the FieldSpec to allow ingesting long strings, but the property length limit is fixed. Also, the property length limit also applies to the BYTES column.
siddharthteotia
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent storing very long values into the segment metadata. This could happen for text column, bytes column for serialized objects, or blob store use cases (not recommended but supported).