[Clean up] Separate TextIndex from InvertedIndex #6010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,14 +43,14 @@ | |||
| InvertedIndexReader<?> getInvertedIndex(); | |||
|
|
|||
| /** | |||
| * Returns the inverted index for the column, or {@code null} if it does not exist. | |||
| * Returns the range index for the column, or {@code null} if it does not exist. | |||
There was a problem hiding this comment.
Are we planning to do similar cleanup for range index as well? It is also based off InvertedIndex (for the same reasons why TextIndex was based)
There was a problem hiding this comment.
Yes, will do that in a separate PR. We need to design the interface for the range index
siddharthteotia
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce
TextIndexCreatorandTextIndexReaderfor text index