Table indexing config validation #6017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcvsubbu
reviewed
Sep 15, 2020
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
Show resolved
Hide resolved
jackjlli
reviewed
Sep 15, 2020
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
Show resolved
Hide resolved
npawar
reviewed
Sep 15, 2020
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
Show resolved
Hide resolved
…Adding javadocs * Bug fix in integration test regarding removal of existing column from schema
npawar
reviewed
Sep 17, 2020
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
Outdated
Show resolved
Hide resolved
|
As discussed offline, it would be nice to have some validations on index columns which cannot be in noDictionary columns (e.g. if column has inverted index, it should not be in noDictionary). |
Not in this PR. I'll create a separate one for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5942
Description
This is to ensure any column name mentioned in the table indexing config is valid (i.e. it exists in the corresponding schema). Also checking for space in the table name.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
No
Does this PR fix a zero-downtime upgrade introduced earlier?
No
Does this PR otherwise need attention when creating release notes?
No